Added brew Formulae file #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell the brew formulae works and properly installs spotify-dl. There are a few things worth noting though:
As of now I have only tested it on my machine (running macOS 11.6 Big Sur). It would be good if other people with different versions of macOS or Linux could try out this formulae to make sure that it works.
I've done the bare minimum (according to my knowledge) to get this formulae to work. There are likely many improvements and modifications that can be made (extra metadata, tests, pre-compiled binaries ...) and I encourage anyone with experience with brew to review this formulae and suggest changes.
Lastly, once we are happy with the formulae we should submit the formulae to homebrew-core by opening a PR, so that spotify-dl can be made available for the masses through brew. The other option here, is to create our own tap (like a package registry for brew) and host the formulae ourselves, however this approach isn't recommended since we would have to host & maintain the tap and our formulae would not be directly available with brew by default (users would need to add our tap first).
As I am still new to creating formulaes for brew, having another set of eyes on this would be very helpful 😄 .
In response to issue #89 .